server : add try..catch to places not covered by set_exception_handler #11620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbev
approved these changes
Feb 3, 2025
ggerganov
approved these changes
Feb 3, 2025
examples/server/server.cpp
Outdated
Comment on lines
3356
to
3363
| try { | ||
| LOG_INF("request: %s %s %s %d\n", req.method.c_str(), req.path.c_str(), req.remote_addr.c_str(), res.status); | ||
|
|
||
| LOG_DBG("request: %s\n", req.body.c_str()); | ||
| LOG_DBG("response: %s\n", res.body.c_str()); | ||
| LOG_DBG("request: %s\n", req.body.c_str()); | ||
| LOG_DBG("response: %s\n", res.body.c_str()); | ||
| } catch (const std::exception & e) { | ||
| LOG_ERR("failed to log request/response: %s\n", e.what()); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
No, but this is mostly for future-proof.
Indeed, I was a bit doubt when adding this try..catch because I want to communicate to whoever in the future touching this code that "exception is not handled here". Another solution is to just add a TODO, but not sure if it's enough because people may not even read it.
Member
There was a problem hiding this comment.
IMO it's fine to remove the try/catch if it is not currently used.
Collaborator
Author
There was a problem hiding this comment.
OK I replaced the try catch with a comment
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
ggml-org#11620) * server : add try..catch to places not covered by set_exception_handler * log_server_request: rm try catch, add reminder
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
ggml-org#11620) * server : add try..catch to places not covered by set_exception_handler * log_server_request: rm try catch, add reminder
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
ggml-org#11620) * server : add try..catch to places not covered by set_exception_handler * log_server_request: rm try catch, add reminder
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
ggml-org#11620) * server : add try..catch to places not covered by set_exception_handler * log_server_request: rm try catch, add reminder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For httplib, the exceptions inside
set_exception_handlerandset_loggerare not being handled